Run tests (do not merge this change). #2345
Conversation
![datadog-datadog-prod-us1[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
| return data if data.instance_of?(Hash) | ||
| when 'UUID' | ||
| return UUIDTools::UUID.parse(data) | ||
| raise TypeError, "Expected String, got #{uuid_string.class.name} instead." unless uuid_string.kind_of?(String) |
There was a problem hiding this comment.
⚪ Code Quality Violation
| raise TypeError, "Expected String, got #{uuid_string.class.name} instead." unless uuid_string.kind_of?(String) | |
| raise TypeError, "Expected String, got #{uuid_string.class.name} instead." unless uuid_string.is_a?(String) |
Prefer is_a? over kind_of? (...read more)
The rule "Prefer is_a? over kind_of?" suggests to use the method is_a? instead of kind_of? in your Ruby code. Both is_a? and kind_of? methods check if an object is an instance of a class or its subclasses. However, is_a? is generally preferred due to its clear and concise terminology.
This rule is important for maintaining consistency and readability in your code. Using is_a? makes your code more understandable to other developers because its function is immediately apparent from its name. On the other hand, kind_of? might lead to confusion as it's not as clear in its function.
To avoid this rule violation, always use the is_a? method when you want to check the class of an object. For example, instead of writing something.kind_of?(Array), you should write something.is_a?(Array). This will make your code easier to read and understand, leading to better maintainability and fewer bugs.
jack-edmonds-dd
force-pushed
the
run-tests
branch
2 times, most recently
from
6d4c356 to
3b86f52
Compare
What does this PR do?
Additional Notes
Review checklist
Please check relevant items below:
This PR includes all newly recorded cassettes for any modified tests.
This PR does not rely on API client schema changes.
Or, this PR relies on API schema changes and this is a Draft PR to include tests for that new functionality.